#05 Codex Sub-Agents v2 (Quality)

Quality

codex-subagents-2 · v0.101.0

Tool Calls

898

22 unique tools

Total Tokens

100.8M

226.6K output

Subagents

53

36 explorers, 17 workers

Reasoning

836

135 commentary msgs

Code Quality Assessment

PHPMetrics

Code Quality Assessment

PHPMetrics 2.9.1

Classes

141

Lines of Code

7.2K

Avg MI

79.6

Avg Complexity

9.2

Est. Bugs

31.4

max 4.8 in CheckoutController

Violations

63

32 errors, 25 warnings

Complexity Distribution

Low (CCN <= 10)
118 (83.7%)
Medium (11-20)
9 (6.4%)
High (> 20)
14 (9.9%)

Maintainability Distribution

Excellent (>= 85)
76 (53.9%)
Good (70-84)
21 (14.9%)
Moderate (55-69)
23 (16.3%)
Low (< 55)
21 (14.9%)

Most Complex Classes

ClassCCNLOCMI
CheckoutController
Api\Storefront
174420
20
CheckoutController
Storefront
109310
25
AdminPageController
Admin
75280
23
CartService
App\Services
48195
32
OrderService
App\Services
42170
35

Least Maintainable Classes

ClassMICCNLOC
CheckoutController
Api\Storefront
20
174420
AdminPageController
Admin
23
75280
CheckoutController
Storefront
25
109310
CartService
App\Services
32
48195
OrderService
App\Services
35
42170

Most Coupled Classes

AdminPageController
26
CheckoutController (API)
18
CheckoutController (Storefront)
15
OrderService
14
Store (Model)
12

Violations (63)

Critical0
Errors32
Warnings25
Info6

· Too complex class code (multiple controllers)

· Too complex method code (checkout and cart logic)

· Blob / God object (AdminPageController - 26 dependencies, high LCOM)

· Probably bugged (high Halstead defect estimates in checkout)

· Too long (excessive LOC in controller classes)

· Too dependent (high efferent coupling in admin controller)

Halstead & Coupling

Total Est. Bugs31.4
Avg Bugs/Class0.223
Avg Defects (Kan)0.45
Max Efferent Coupling26
Avg Instability0.72
Max LCOM6
Avg LOC/Class50.9

SonarCloud Analysis

PR #5 - Quality Gate Failed
FAIL

Quality Gate: Failed

PR #5 · codex-subagents-2main

33.3h technical debt

153 issues total

View on SonarCloud

Quality Gate Conditions

Duplicated Lines
5.3%> 3.0%
Security Hotspots Reviewed
0.0%< 100%

Bugs

0

A

Reliability

Vulnerabilities

0

A

Security

Code Smells

153

A

Maintainability

Hotspots

5

0% reviewed

Lines of Code

16.2K

PHP

Duplication

4.2%

on new code

Coverage

0%

not configured

Issues by Severity

Critical
69
Major
53
Minor
31
Total153

Issues by Type

Code Smells
153 (100.0%)
Security Hotspots
5 (3.3%)
Bugs
0 (0.0%)
Vulnerabilities
0 (0.0%)
Zero bugs and zero vulnerabilities - all ratings A

Top Issue Rules

Duplicate String LiteralsS1192
55
CRITICAL
Excessive Return StatementsS1142
41
MAJOR
Immediately Return VariableS1488
30
MINOR
Cognitive ComplexityS3776
14
CRITICAL
Unused Function ParametersS1172
5
MAJOR
Generic Exception UsageS112
4
MAJOR
Commented-Out CodeS125
3
MAJOR
Nested Ternary OperationsS3358
2
CRITICAL

String duplication dominates with 55 issues (S1192). Despite using custom instructions with PHPStan and Deptrac, code smells tripled compared to v1 (153 vs 54), likely due to the larger codebase. However, zero bugs and zero vulnerabilities indicate that the quality-focused approach improved correctness.